[FSDP] Add fast path for NO_SHARD clip_grad_norm_()
#89137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
awgu
requested review from
mrshenli,
pritamdamania87,
zhaojuanmao,
rohan-varma,
H-Huang and
kwen2501
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89137
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ab9f9de: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
awgu
added a commit
that referenced
this pull request
Nov 16, 2022
ghstack-source-id: e5ad011e74f0dd5cf7a1e3d96db35682705aa2e1 Pull Request resolved: #89137
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Nov 16, 2022
ghstack-source-id: e5ad011e74f0dd5cf7a1e3d96db35682705aa2e1 Pull Request resolved: pytorch#89137
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Nov 16, 2022
ghstack-source-id: df801495fc5517d7420e151ad8a5807627e1f5cc Pull Request resolved: #89137
rohan-varma
approved these changes
Nov 16, 2022
| # TODO: Gradient computation on CPU and GPU differ slightly causing | ||
| # drift unrelated to `clip_grad_norm_()`. | ||
| # https://github.com/pytorch/pytorch/issues/89133 | ||
| return |
There was a problem hiding this comment.
A bit hacky, but would it help if we just ran DDP on CPU for this case if having this coverage is important?
There was a problem hiding this comment.
Does DDP work on CPU with NCCL backend?
awgu
added a commit
to awgu/pytorch
that referenced
this pull request
Nov 16, 2022
ghstack-source-id: df801495fc5517d7420e151ad8a5807627e1f5cc Pull Request resolved: pytorch#89137
[ghstack-poisoned]
awgu
added a commit
that referenced
this pull request
Nov 16, 2022
ghstack-source-id: 0dd6ff61ca05986e32893b082e76f4341f1af61e Pull Request resolved: #89137
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Pull Request resolved: pytorch#89137 Approved by: https://github.com/rohan-varma
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
NO_SHARDclip_grad_norm_()#89137 [FSDP] Add fast path forNO_SHARDclip_grad_norm_()