Removed unecessary check in select_nested
#89150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89150
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4eb5a65: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mikaylagawarecki
added a commit
that referenced
this pull request
Nov 16, 2022
ghstack-source-id: de957247148d49ef64f78dda22dde6f72502bb98 Pull Request resolved: #89150
mikaylagawarecki
changed the title
select_nested
Implementation in #88585 should work for all dimensions. Removed unnecessary check that constrained select to dims 0 and 1 [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Nov 16, 2022
ghstack-source-id: fc65337e28adc63e5ef725dad2812a0cfe1d1ae5 Pull Request resolved: #89150
mikaylagawarecki
added
release notes: nested tensor
Implementation in #88585 should work for all dimensions. Removed unnecessary check that constrained select to dims 0 and 1 [ghstack-poisoned]
mikaylagawarecki
added a commit
that referenced
this pull request
Nov 16, 2022
ghstack-source-id: 0af5f34a72e59667a6a1c139afe9a764c36b5a5f Pull Request resolved: #89150
cpuhrsch
approved these changes
Nov 16, 2022
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Implementation in pytorch#88585 should work for all dimensions. Removed unnecessary check that constrained select to dims 0 and 1 Pull Request resolved: pytorch#89150 Approved by: https://github.com/cpuhrsch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
select_nested#89150Implementation in #88585 should work for all dimensions. Removed unnecessary check that constrained select to dims 0 and 1