Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PT-D][1/N] Sync TP Beta change to prod #89242

Closed
wants to merge 8 commits into from
Closed

[PT-D][1/N] Sync TP Beta change to prod #89242

wants to merge 8 commits into from

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Nov 17, 2022

This is part of TP Beta Release efforts.

ref: pytorch/PiPPy#576

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 17, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89242

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 Failures

As of commit 4548389:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj fduwjj added the release notes: distributed (dtensor) release notes category label Nov 17, 2022
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! please make sure CI pass before landing

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 17, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 17, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule Distributed):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge -f trunk test failure only.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2022

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: test failure only.

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 19, 2022

@pytorchbot merge -f "CI failure is in trunk not this PR related."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
This is part of TP Beta Release efforts.

ref: pytorch/PiPPy#576

Pull Request resolved: pytorch#89242
Approved by: https://github.com/wanchaol
@github-actions github-actions bot deleted the sync_tp branch May 30, 2024 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (dtensor) release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants