Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard the boundary of index computed in compute_source_index_and_lambda #89252

Closed
wants to merge 4 commits into from
Closed

Guard the boundary of index computed in compute_source_index_and_lambda #89252

wants to merge 4 commits into from

Conversation

jgong5
Copy link
Collaborator

@jgong5 jgong5 commented Nov 18, 2022

Improve the fix in #89210
See discussion in #89212 (comment)

@jgong5 jgong5 requested a review from malfet November 18, 2022 00:48
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89252

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99849a5:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 18, 2022
@jgong5 jgong5 requested a review from vfdev-5 November 19, 2022 05:01
@jgong5 jgong5 mentioned this pull request Nov 21, 2022
Closed
@jgong5
Copy link
Collaborator Author

jgong5 commented Nov 29, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 29, 2022
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
chowarfb, drisspg, idning, great-way, zhangxy988, ...

Details for Dev Infra team Raised by workflow job

@jgong5
Copy link
Collaborator Author

jgong5 commented Nov 29, 2022

hi @weiwangmeta May I ask your help to land it? @mingfeima reviewed and approved. Thanks!

weiwangmeta
weiwangmeta approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@weiwangmeta weiwangmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Signals are green & LGTM

@jgong5
Copy link
Collaborator Author

jgong5 commented Nov 29, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@jgong5
Copy link
Collaborator Author

jgong5 commented Nov 29, 2022

@pytorchbot rebase

@jgong5
Copy link
Collaborator Author

jgong5 commented Nov 29, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased jgong5/guard_compute_source_index_and_lambda onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout jgong5/guard_compute_source_index_and_lambda && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the jgong5/guard_compute_source_index_and_lambda branch from 0b10498 to 99849a5 Compare November 29, 2022 11:12
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@jgong5 @kulinseth
Guard the boundary of index computed in compute_source_index_and_lamb…
7dd6e75 
…da (pytorch#89252)

Improve the fix in pytorch#89210
See discussion in pytorch#89212 (comment)
Pull Request resolved: pytorch#89252
Approved by: https://github.com/mingfeima, https://github.com/weiwangmeta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingfeima mingfeima mingfeima approved these changes

@weiwangmeta weiwangmeta weiwangmeta approved these changes

@malfet malfet Awaiting requested review from malfet

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jgong5 @pytorchmergebot @vfdev-5 @mingfeima @weiwangmeta @soulitzer @pytorchbot