Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Autograd Documentation Clarity #89401

Closed
wants to merge 1 commit into from
Closed

Improve Autograd Documentation Clarity #89401

wants to merge 1 commit into from

Conversation

ArekSredzki
Copy link
Contributor

@ArekSredzki ArekSredzki commented Nov 21, 2022 •
edited by pytorch-bot bot

This makes minor adjustments to the autograd docs, improving clarity and resolving grammatical errors

cc @svekars @carljparker

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89401

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 817ea18:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 21, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ArekSredzki / name: Arek Sredzki (37ce542)

@kit1980 kit1980 requested a review from svekars November 21, 2022 21:13
svekars
svekars reviewed Nov 22, 2022
View reviewed changes
docs/source/notes/autograd.rst Outdated Show resolved Hide resolved
docs/source/notes/autograd.rst Outdated Show resolved Hide resolved
@H-Huang H-Huang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 22, 2022
svekars
svekars reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@svekars svekars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kit1980
kit1980 requested changes Nov 29, 2022
View reviewed changes
Copy link
Member

@kit1980 kit1980 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the document renders correctly after the changes.

docs/source/notes/autograd.rst Outdated Show resolved Hide resolved
@kit1980
Copy link
Member

kit1980 commented Dec 2, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 2, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (jit_legacy, 1, 1, linux.4xlarge.nvidia.gpu) ,trunk / win-vs2019-cuda11.6-py3 / test (default, 4, 5, windows.8xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@ArekSredzki
Copy link
Contributor Author

Thanks for trying to merge this @kit1980. It's not clear to me why some of the CI stages failed, does anything stand out to you?

@kit1980
Copy link
Member

kit1980 commented Dec 6, 2022

Thanks for trying to merge this @kit1980. It's not clear to me why some of the CI stages failed, does anything stand out to you?

Probably some flakiness. I've restarted the failed jobs.

@kit1980
Copy link
Member

kit1980 commented Dec 6, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Member

kit1980 commented Dec 6, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@ArekSredzki @pytorchmergebot
Improve Autograd Documentation Clarity
817ea18 
This makes minor adjustments to the autograd docs, improving clarity and resolving grammatical errors
@pytorchmergebot
Copy link
Collaborator

Successfully rebased patch-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout patch-1 && git pull --rebase)

@kit1980
Copy link
Member

kit1980 commented Dec 6, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #89401, but it was already up to date

@kit1980
Copy link
Member

kit1980 commented Dec 6, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Member

kit1980 commented Dec 6, 2022

@pytorchbot merge -f "Doc change only, unrelated triton install failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@ArekSredzki @kulinseth
Improve Autograd Documentation Clarity (pytorch#89401)
076d87f 
This makes minor adjustments to the autograd docs, improving clarity and resolving grammatical errors

Pull Request resolved: pytorch#89401
Approved by: https://github.com/kit1980
@drisspg drisspg added the module: docs Related to our documentation, both in docs/ and docblocks label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svekars svekars svekars left review comments

@kit1980 kit1980 kit1980 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: docs Related to our documentation, both in docs/ and docblocks open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ArekSredzki @kit1980 @pytorchmergebot @svekars @H-Huang @pytorchbot @drisspg