Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev-discuss link in the maintainer docs #89493

Closed
wants to merge 1 commit into from
Closed

Fix dev-discuss link in the maintainer docs #89493

wants to merge 1 commit into from

Conversation

qqaatw
Copy link
Collaborator

@qqaatw qqaatw commented Nov 22, 2022 •
edited by pytorch-bot bot

Fixes #ISSUE_NUMBER

cc @svekars @carljparker

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89493

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 72e8cde:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@qqaatw
Copy link
Collaborator Author

qqaatw commented Nov 22, 2022

@pytorchbot label "module: docs"

@pytorch-bot pytorch-bot bot added the module: docs Related to our documentation, both in docs/ and docblocks label Nov 22, 2022
H-Huang
H-Huang approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@H-Huang
Copy link
Member

H-Huang commented Nov 22, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 22, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@qqaatw
Copy link
Collaborator Author

qqaatw commented Nov 22, 2022

@H-Huang I think we can force merge this?

@H-Huang
Copy link
Member

H-Huang commented Nov 22, 2022

@pytorchbot merge -f "Doc changes, CI failure is unrelated"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@qqaatw @kulinseth
Fix dev-discuss link in the maintainer docs (pytorch#89493)
f40df9b 
Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#89493
Approved by: https://github.com/H-Huang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H-Huang H-Huang H-Huang approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: docs Related to our documentation, both in docs/ and docblocks open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qqaatw @H-Huang @pytorchmergebot @pytorchbot