Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C2 Ambiguous namespace #89534

Closed
wants to merge 1 commit into from
Closed

Fix C2 Ambiguous namespace #89534

wants to merge 1 commit into from

Conversation

xw285cornell
Copy link
Contributor

@xw285cornell xw285cornell commented Nov 22, 2022 •
edited

Summary: cuda:: is a ambiguous namespace. Make it explicit c10::cuda

Differential Revision: D41469007
/caffe2/caffe2/core/context_gpu.cu(564): error: "caffe2::cuda" is ambiguous/caffe2/caffe2/core/context_gpu.cu(564): error: expected a ";"/caffe2/caffe2/core/context_gpu.cu(568): warning #12-D: parsing restarts here after previous syntax error
Remark: The warnings can be suppressed with "-diag-suppress "/caffe2/caffe2/core/context_gpu.cu(569): error: "caffe2::cuda" is ambiguous/caffe2/caffe2/core/context_gpu.cu(628): error: "caffe2::cuda" is ambiguous
4 errors detected in the compilation of "/caffe2/caffe2/core/context_gpu.cu".

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89534

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit fb959e7:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 22, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: xw285cornell / name: Xiaodong Wang (fb959e7)

@pytorch-bot pytorch-bot bot added the caffe2 label Nov 22, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41469007

@xw285cornell @facebook-github-bot
Fix C2 Ambiguous namespace (pytorch#89534)
fb959e7 
Summary:
Pull Request resolved: pytorch#89534

cuda:: is a ambiguous namespace. Make it explicit c10::cuda

Differential Revision: D41469007

fbshipit-source-id: 80039320025383750a590d7f1f8ce45a197a6d29
@xw285cornell
Copy link
Contributor Author

/easycla

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41469007

@xw285cornell
Copy link
Contributor Author

/easycla

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 7, 2022
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@xw285cornell @kulinseth
Fix C2 Ambiguous namespace (pytorch#89534)
ab4d2a6 
Summary: cuda:: is a ambiguous namespace. Make it explicit c10::cuda

Differential Revision: D41469007
/caffe2/caffe2/core/context_gpu.cu(564): error: "caffe2::cuda" is ambiguous/caffe2/caffe2/core/context_gpu.cu(564): error: expected a ";"/caffe2/caffe2/core/context_gpu.cu(568): warning #12-D: parsing restarts here after previous syntax error
Remark: The warnings can be suppressed with "-diag-suppress <warning-number>"/caffe2/caffe2/core/context_gpu.cu(569): error: "caffe2::cuda" is ambiguous/caffe2/caffe2/core/context_gpu.cu(628): error: "caffe2::cuda" is ambiguous
4 errors detected in the compilation of "/caffe2/caffe2/core/context_gpu.cu".

Pull Request resolved: pytorch#89534
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet approved these changes

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
caffe2 ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xw285cornell @facebook-github-bot @pytorchmergebot @malfet