Call symint::sizes() instead of sizes() on convolution error messages.
#89549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89549
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 43239b8: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
added
the
module: cpu
ezyang
approved these changes
Nov 23, 2022
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…ages. (pytorch#89549) This PR fixes convolution when using `torchdynamo` with dynamic shapes. **Problem:** there are some `tensor.sizes()` calls in a few error messages. As a result, an uninformative error message was being displayed. ```python @torch._dynamo.optimize("eager") def foo(inp, w): return F.conv2d(inp, w) inp = torch.rand((1, 1, 32, 32)) w = torch.rand((1, 2, 3, 3)) # | # |--------- incorrect shape! foo(inp, w) ``` ----- **Before this PR:** ```python Traceback (most recent call last): File "torch/_dynamo/utils.py", line 1076, in run_node return node.target(*args, **kwargs) File "torch/_subclasses/fake_tensor.py", line 867, in __torch_dispatch__ op_impl_out = op_impl(self, func, *args, **kwargs) File "torch/_subclasses/fake_tensor.py", line 445, in conv conv_backend = torch._C._select_conv_backend(**kwargs) RuntimeError: Cannot call sizes() on tensor with symbolic sizes/strides ``` **After this PR:** ```python Traceback (most recent call last): File "torch/_dynamo/utils.py", line 1076, in run_node return node.target(*args, **kwargs) File "torch/_subclasses/fake_tensor.py", line 867, in __torch_dispatch__ op_impl_out = op_impl(self, func, *args, **kwargs) File "torch/_subclasses/fake_tensor.py", line 445, in conv conv_backend = torch._C._select_conv_backend(**kwargs) RuntimeError: Given groups=1, weight of size [1, s1, s2, s2], expected input[1, 1, s0, s0] to have s1 channels, but got 1 channels instead ``` Pull Request resolved: pytorch#89549 Approved by: https://github.com/ezyang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes convolution when using
torchdynamowith dynamic shapes.Problem: there are some
tensor.sizes()calls in a few error messages. As a result, an uninformative error message was being displayed.Before this PR:
After this PR:
cc @VitalyFedyunin @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10