Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHA] Decrease Windows test timeout to 120 minutes #89694

Closed
wants to merge 1 commit into from

Conversation

Blackhex
Copy link
Collaborator

@Blackhex Blackhex commented Nov 25, 2022

This PR decreases the Windows tests pipelines timeout to 120 mins per discusison as requested at #73489 (comment)

Closes #73489.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 25, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89694

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 Failures

As of commit ddcf919:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@Blackhex Blackhex added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/nightly Trigger all jobs we run nightly (nightly.yml) labels Nov 28, 2022
@Blackhex Blackhex changed the title [WIP][GHA] Decrease Windows test timeout to 120 minutes [GHA] Decrease Windows test timeout to 120 minutes Nov 28, 2022
@Blackhex Blackhex marked this pull request as ready for review November 28, 2022 12:07
@Blackhex Blackhex requested a review from a team as a code owner November 28, 2022 12:07
@kit1980
Copy link
Member

kit1980 commented Nov 28, 2022

@pytorchbot merge -f "Irrelevant Linux test failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@clee2000
Copy link
Contributor

@pytorchbot revert -m "broke periodic b/c they take ~2.5 hrs, also broke mem leak check b/c its slow, should probably look into having this be a parameter" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@Blackhex your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Nov 29, 2022
This reverts commit faa032c.

Reverted #89694 on behalf of https://github.com/clee2000 due to broke periodic b/c they take ~2.5 hrs, also broke mem leak check b/c its slow, should probably look into having this be a parameter
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
This PR decreases the Windows tests pipelines timeout to 120 mins per discusison as requested at pytorch#73489 (comment)

Closes pytorch#73489.
Pull Request resolved: pytorch#89694
Approved by: https://github.com/kit1980
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
…9694)"

This reverts commit faa032c.

Reverted pytorch#89694 on behalf of https://github.com/clee2000 due to broke periodic b/c they take ~2.5 hrs, also broke mem leak check b/c its slow, should probably look into having this be a parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/nightly Trigger all jobs we run nightly (nightly.yml) ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source Reverted topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows tests frequently timeout
5 participants