Update minor release acceptance criteria #89767
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update minor release acceptance criteria
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89767
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dabce3f: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
albanD
approved these changes
Nov 28, 2022
|
@pytorchmergebot merge -f "document oly change" |
weiwangmeta
approved these changes
Nov 28, 2022
| @@ -241,13 +241,11 @@ For patch releases issue tracker needs to be created. For patch release, we requ | |||
| * https://github.com/pytorch/pytorch/issues/51886 | |||
|
|
|||
| Only following issues are accepted: | |||
| 1. Fixes to regressions against previous major version | |||
| 1. Fixes to regressions against previous major version (e.g. regressions introduced in 1.13.0 from 1.12.0 are pickable for 1.13.1) | |||
There was a problem hiding this comment.
Should people interpret "from 1.12.0" == "after 1.12.0"?
There was a problem hiding this comment.
I think its quite clear 1.12.0 - no regression
1.13.0 - regression is introduced
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Update minor release acceptance criteria Pull Request resolved: pytorch#89767 Approved by: https://github.com/albanD, https://github.com/weiwangmeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update minor release acceptance criteria