Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PT-D][Tensor Parallel] Add more test cases when we use use_orig_params for FSDP wrapping #89779

Closed
wants to merge 7 commits into from
Closed

[PT-D][Tensor Parallel] Add more test cases when we use use_orig_params for FSDP wrapping #89779

wants to merge 7 commits into from

Conversation

fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Nov 28, 2022 •
edited

@fduwjj
[PT-D][Tensor Parallel] Sync change to pytorch and Add more test case…
24bf4ac 
…s when we use use_orig_params for FSDP wrapping

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 28, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89779

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 0a3ee14:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

fduwjj added a commit that referenced this pull request Nov 28, 2022
@fduwjj
[PT-D][Tensor Parallel] Sync change to pytorch and Add more test case…
a63874c 
…s when we use use_orig_params for FSDP wrapping

ghstack-source-id: e895a29595d85de2ea116c4999337dfcc86795f1
Pull Request resolved: #89779
wanchaol
wanchaol approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, one comment about removing experimental op

torch/distributed/_tensor/ops/math_ops.py Outdated Show resolved Hide resolved
@wanchaol wanchaol mentioned this pull request Nov 28, 2022
Closed
@fduwjj
Update on "[PT-D][Tensor Parallel] Sync change to pytorch and Add mor…
1cd9dcb 
…e test cases when we use use_orig_params for FSDP wrapping"

[ghstack-poisoned]
fduwjj added a commit that referenced this pull request Nov 29, 2022
@fduwjj
[PT-D][Tensor Parallel] Sync change to pytorch and Add more test case…
b2ba8ca 
…s when we use use_orig_params for FSDP wrapping

ghstack-source-id: a26f0a2e81df1d645e506788a8ecd67143bc854b
Pull Request resolved: #89779
@fduwjj
Update on "[PT-D][Tensor Parallel] Sync change to pytorch and Add mor…
e82b712 
…e test cases when we use use_orig_params for FSDP wrapping"

[ghstack-poisoned]
fduwjj added a commit that referenced this pull request Nov 29, 2022
@fduwjj
[PT-D][Tensor Parallel] Sync change to pytorch and Add more test case…
a3c0b93 
…s when we use use_orig_params for FSDP wrapping

ghstack-source-id: 24816e798a84b9324ceda8bad42b74832e0ef489
Pull Request resolved: #89779
@fduwjj
Update on "[PT-D][Tensor Parallel] Sync change to pytorch and Add mor…
3334f26 
…e test cases when we use use_orig_params for FSDP wrapping"

[ghstack-poisoned]
fduwjj added a commit that referenced this pull request Nov 29, 2022
@fduwjj
[PT-D][Tensor Parallel] Sync change to pytorch and Add more test case…
afec5b1 
…s when we use use_orig_params for FSDP wrapping

ghstack-source-id: bc5994f6e3bd9bf1b380994cae5785cd5a7c4ff4
Pull Request resolved: #89779
@fduwjj
Update on "[PT-D][Tensor Parallel] Sync change to pytorch and Add mor…
328feb2 
…e test cases when we use use_orig_params for FSDP wrapping"

[ghstack-poisoned]
fduwjj added a commit that referenced this pull request Nov 29, 2022
@fduwjj
[PT-D][Tensor Parallel] Sync change to pytorch and Add more test case…
67b91a1 
…s when we use use_orig_params for FSDP wrapping

ghstack-source-id: 4ab7bb75eb220e05cd75b22e6f5440fe741ddc9e
Pull Request resolved: #89779
@fduwjj fduwjj added the release notes: distributed (dtensor) release notes category label Nov 30, 2022
@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 30, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 30, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 30, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 30, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@fduwjj
Update on "[PT-D][Tensor Parallel] Sync change to pytorch and Add mor…
cfcac45 
…e test cases when we use use_orig_params for FSDP wrapping"

Differential Revision: [D41600656](https://our.internmc.facebook.com/intern/diff/D41600656)

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/fduwjj/50/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/89779)

pytorchmergebot pushed a commit that referenced this pull request Nov 30, 2022
@fduwjj
[PT-D][Tensor Parallel] Sync change to pytorch and Add more test case…
d514720 
…s when we use use_orig_params for FSDP wrapping

ghstack-source-id: fee6b6aa0fb912ce284513f78ab3c9e80f221245
Pull Request resolved: #89779
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 30, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@fduwjj fduwjj changed the title [PT-D][Tensor Parallel] Sync change to pytorch and Add more test cases when we use use_orig_params for FSDP wrapping [PT-D][Tensor Parallel] Add more test cases when we use use_orig_params for FSDP wrapping Nov 30, 2022
@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 30, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team Raised by workflow job

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 30, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@fduwjj
Update on "[PT-D][Tensor Parallel] Add more test cases when we use us…
0a3ee14 
…e_orig_params for FSDP wrapping"

Differential Revision: [D41600656](https://our.internmc.facebook.com/intern/diff/D41600656)

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/fduwjj/50/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/89779)

pytorchmergebot pushed a commit that referenced this pull request Nov 30, 2022
@fduwjj
[PT-D][Tensor Parallel] Sync change to pytorch and Add more test case…
dbe3cc3 
…s when we use use_orig_params for FSDP wrapping

ghstack-source-id: 67280ba4720d1b1da29dd1e9bb2c799cdc65e32e
Pull Request resolved: #89779
@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 30, 2022

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@fduwjj
Copy link
Contributor Author

fduwjj commented Nov 30, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@fduwjj @kulinseth
[PT-D][Tensor Parallel] Add more test cases when we use use_orig_para…
1eefdde 
…ms for FSDP wrapping (pytorch#89779)

Differential Revision: [D41600656](https://our.internmc.facebook.com/intern/diff/D41600656)
Pull Request resolved: pytorch#89779
Approved by: https://github.com/wanchaol
@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/50/head branch June 8, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wanchaol wanchaol wanchaol approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (dtensor) release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fduwjj @pytorchmergebot @wanchaol