[MHA] replace double transpose with single permute in nn.f.mha #89847
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89847
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 950ede2: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
drisspg
added
the
better-engineering
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
drisspg
force-pushed
the
quick_code_clean_up
branch
from
f90f37a
to
950ede2
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Need to revert this commit as it is causing conflict when reverting #89470" -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@drisspg your PR has been successfully reverted. |
)" This reverts commit b9afa92. Reverted #89847 on behalf of https://github.com/jeanschmidt due to Need to revert this commit as it is causing conflict when reverting #89470
# Summary I forgot about permute which was exactly what I wanted. Quick perf bump Pull Request resolved: pytorch#89847 Approved by: https://github.com/cpuhrsch, https://github.com/albanD
…orch#89847)" This reverts commit b9afa92. Reverted pytorch#89847 on behalf of https://github.com/jeanschmidt due to Need to revert this commit as it is causing conflict when reverting pytorch#89470
drisspg
changed the title
Summary
I forgot about permute which was exactly what I wanted. Quick perf bump