Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta registration for aten._cdist_forward #90042

Closed
wants to merge 1 commit into from
Closed

Fix meta registration for aten._cdist_forward #90042

wants to merge 1 commit into from

Conversation

yanboliang
Copy link
Contributor

Error from 7k github model.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90042

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 107d2ed:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

yanboliang
yanboliang commented Dec 2, 2022
View reviewed changes
torch/_meta_registrations.py
compute_mode >= 0 and compute_mode <= 2,
lambda: f"possible modes: 0, 1, 2, but was: {compute_mode}",
compute_mode in (None, 1, 2),
lambda: f"possible modes: None, 1, 2, but was: {compute_mode}",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We pass None rather than 0 at https://github.com/pytorch/pytorch/blob/master/torch/functional.py#L1222.

@ezyang
Copy link
Contributor

ezyang commented Dec 2, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 2, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

eellison
eellison approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: linux-binary-manywheel ,linux-binary-manywheel / manywheel-py3_7-cuda11_6-test / build

Details for Dev Infra team Raised by workflow job

@yanboliang
Copy link
Contributor Author

@pytorchbot merge -f "irrelevant build failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yanboliang yanboliang deleted the cdist branch December 2, 2022 21:14
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@yanboliang @kulinseth
Fix meta registration for aten._cdist_forward (pytorch#90042)
eece39f 
Error from [7k github model](https://github.com/pytorch/torchdynamo/issues/1884).

Pull Request resolved: pytorch#90042
Approved by: https://github.com/ezyang, https://github.com/eellison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@eellison eellison eellison approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yanboliang @ezyang @pytorchmergebot @eellison