Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generator argument to torch.rand docstring #90071

Closed
wants to merge 1 commit into from
Closed

Add generator argument to torch.rand docstring #90071

wants to merge 1 commit into from

Conversation

cherrywoods
Copy link
Contributor

@cherrywoods cherrywoods commented Dec 2, 2022 •
edited by pytorch-bot bot

The documentation of torch.rand was missing the generator keyword argument in the function signature. However, the argument is explained in the documentation and torch.rand accepts that argument.

cc @svekars @carljparker

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90071

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6488647:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: python_frontend release notes category label Dec 2, 2022
@janeyx99 janeyx99 added the module: docs Related to our documentation, both in docs/ and docblocks label Dec 2, 2022
janeyx99
janeyx99 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kit1980
Copy link
Member

kit1980 commented Dec 4, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 4, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kit1980
Copy link
Member

kit1980 commented Dec 4, 2022

@pytorchbot merge -f "Doc generation only change, lint passed"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@cherrywoods @kulinseth
Add generator argument to torch.rand docstring (pytorch#90071)
fb7c4cc 
The documentation of `torch.rand` was missing the `generator` keyword argument in the function signature. However, the argument is explained in the documentation and `torch.rand` accepts that argument.

Pull Request resolved: pytorch#90071
Approved by: https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@svekars svekars Awaiting requested review from svekars

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: docs Related to our documentation, both in docs/ and docblocks open source release notes: python_frontend release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cherrywoods @kit1980 @pytorchmergebot @janeyx99 @pytorchbot