[ReduceOp] ameliorate custom __eq__

[crcrpar]

Improve the completeness of ReduceOp.__eq__.

Should support the equal operator with the first argument of RedOpType and the second of ReduceOp in a follow-up.

Fixes #90072

cc @kwen2501 @pritamdamania87

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90088

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f50e4ff:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[crcrpar]

The failure doesn't look related.

2022-12-02T22:33:34.7404375Z ======================================================================
2022-12-02T22:33:34.7404634Z ERROR [0.004s]: test_dispatch_symbolic_meta_outplace_all_strides_linalg_lu_factor_cuda_float32 (__main__.TestMetaCUDA)
2022-12-02T22:33:34.7404904Z ----------------------------------------------------------------------
2022-12-02T22:33:34.7405040Z Traceback (most recent call last):
2022-12-02T22:33:34.7405393Z   File "/opt/conda/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 2206, in setUp
2022-12-02T22:33:34.7405505Z     set_rng_seed(SEED)
2022-12-02T22:33:34.7405845Z   File "/opt/conda/lib/python3.10/site-packages/torch/testing/_internal/common_utils.py", line 1346, in set_rng_seed
2022-12-02T22:33:34.7405966Z     torch.manual_seed(seed)
2022-12-02T22:33:34.7406270Z   File "/opt/conda/lib/python3.10/site-packages/torch/random.py", line 40, in manual_seed
2022-12-02T22:33:34.7406408Z     torch.cuda.manual_seed_all(seed)
2022-12-02T22:33:34.7406949Z   File "/opt/conda/lib/python3.10/site-packages/torch/cuda/random.py", line 113, in manual_seed_all
2022-12-02T22:33:34.7407226Z     _lazy_call(cb, seed_all=True)
2022-12-02T22:33:34.7407929Z   File "/opt/conda/lib/python3.10/site-packages/torch/cuda/__init__.py", line 176, in _lazy_call
2022-12-02T22:33:34.7408117Z     callable()
2022-12-02T22:33:34.7408646Z   File "/opt/conda/lib/python3.10/site-packages/torch/cuda/random.py", line 111, in cb
2022-12-02T22:33:34.7408902Z     default_generator.manual_seed(seed)
2022-12-02T22:33:34.7409313Z RuntimeError: CUDA error: device-side assert triggered
2022-12-02T22:33:34.7409793Z CUDA kernel errors might be asynchronously reported at some other API call,so the stacktrace below might be incorrect.
2022-12-02T22:33:34.7410097Z For debugging consider passing CUDA_LAUNCH_BLOCKING=1.
2022-12-02T22:33:34.7410125Z 
2022-12-02T22:33:34.7410592Z ----------------------------------------------------------------------
2022-12-02T22:33:34.7410787Z Ran 17244 tests in 915.139s
2022-12-02T22:33:34.7410812Z 
2022-12-02T22:33:34.7411087Z FAILED (errors=1, skipped=9033, expected failures=3)

[kwen2501]

Thanks for the fix and for adding the tests. LGTM.

[crcrpar]

@pytorchbot merge

[pytorchmergebot]

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here