Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Add src/index dynamic axes support for aten::scatter_add #90090

Closed
wants to merge 2 commits into from
Closed

[ONNX] Add src/index dynamic axes support for aten::scatter_add #90090

wants to merge 2 commits into from

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Dec 2, 2022 •
edited by pytorchmergebot

Stack from ghstack (oldest at bottom):

Extend from #89787 , and answer from onnx/onnx#4672, dynamically catching shape of index can let converter further support on this op.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 2, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90090

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 530e336:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Dec 2, 2022
titaiwangms added a commit that referenced this pull request Dec 2, 2022
@titaiwangms
[ONNX] Add src/index dynamic axes support for aten::scatter_add
273a444 
ghstack-source-id: deb8af2fc9fe91c73f801f4240d5feccb4e609da
Pull Request resolved: #90090
@titaiwangms titaiwangms added module: onnx Related to torch.onnx topic: improvements topic category labels Dec 2, 2022
@titaiwangms
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@titaiwangms
Update on "[ONNX] Add src/index dynamic axes support for aten::scatte…
530e336 
…r_add"


Extend from #89787 , and answer from onnx/onnx#4672, dynamically catching shape of index can let converter further support on this op.

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/AllenTiTaiWang/31/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/90090)

pytorchmergebot pushed a commit that referenced this pull request Dec 6, 2022
@titaiwangms
[ONNX] Add src/index dynamic axes support for aten::scatter_add
3e8155c 
ghstack-source-id: 2d67d2f41525000e32863ae5495c6b9e4ee0f03f
Pull Request resolved: #90090
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 6, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@titaiwangms @kulinseth
[ONNX] Add src/index dynamic axes support for aten::scatter_add (pyto…
0bf4fdf 
…rch#90090)

Extend from pytorch#89787 , and answer from onnx/onnx#4672, dynamically catching shape of index can let converter further support on this op.
Pull Request resolved: pytorch#90090
Approved by: https://github.com/BowenBao
@facebook-github-bot facebook-github-bot deleted the gh/AllenTiTaiWang/31/head branch June 8, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BowenBao BowenBao BowenBao approved these changes

@abock abock Awaiting requested review from abock

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@titaiwangms @pytorchmergebot @BowenBao @pytorchbot