Reland: [Autograd] Use in-place input accumulation fast path for dense Tensors. #90217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Tensors. Identical to #88339 except with a `.has_storage()` check before `.storage()`. Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90217
Note: Links to docs will display an error until the docs builds have been completed. ❗ 2 Active SEVsThere are 2 currently active SEVs. If your PR is affected, please view them below: ❌ 6 FailuresAs of commit 7ffc90b: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
robieta
pushed a commit
that referenced
this pull request
Dec 5, 2022
…e Tensors. Identical to #88339 except with a `.has_storage()` check before `.storage()`. Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/) ghstack-source-id: 175170552 Pull Request resolved: #90217
robieta
added
module: autograd
ngimel
approved these changes
Dec 20, 2022
albanD
reviewed
Dec 26, 2022
| buffer[pos] = old_var + var; | ||
| } else if ( | ||
| // ATen doesn't route sparse additions correctly... | ||
| old_var.is_sparse() || old_var.is_sparse_csr()) { |
There was a problem hiding this comment.
cc @cpuhrsch what is the right way (and future proof way) to check if a Tensor is any sparse format?
There was a problem hiding this comment.
@albanD - a future proof catch-all is work in progress. Right now it's best to access the layout and compare to the various sparse formats.
self.layout() == kSparseBsc, self.layout() == kSparseBsr, self.layout() == kSparseCsc, self.layout() == kSparseCsr, self.layout() == kSparse (see Layout.h).
cc @amjames for visibility. I created a new entry in the roadmap for this so we can track it.
…th for dense Tensors." Identical to #88339 except with a `.has_storage()` check before `.storage()`. Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/) cc ezyang albanD zou3519 gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Jan 3, 2023
…e Tensors. Pull Request resolved: #90217 Identical to #88339 except with a `.has_storage()` check before `.storage()`. ghstack-source-id: 177028549 Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/)
…th for dense Tensors." Identical to #88339 except with a `.has_storage()` check before `.storage()`. Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/) cc ezyang albanD zou3519 gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Jan 31, 2023
…e Tensors. Pull Request resolved: #90217 Identical to #88339 except with a `.has_storage()` check before `.storage()`. ghstack-source-id: 178930904 Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/)
…th for dense Tensors." Identical to #88339 except with a `.has_storage()` check before `.storage()`. Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/) cc ezyang albanD zou3519 gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Feb 9, 2023
…e Tensors. Pull Request resolved: #90217 Identical to #88339 except with a `.has_storage()` check before `.storage()`. ghstack-source-id: 179779511 Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/)
robieta
added
ciflow/trunk
…th for dense Tensors." Identical to #88339 except with a `.has_storage()` check before `.storage()`. Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/) cc ezyang albanD zou3519 gqchen pearu nikitaved soulitzer Lezcano Varal7 [ghstack-poisoned]
robieta
pushed a commit
that referenced
this pull request
Feb 10, 2023
…e Tensors. Pull Request resolved: #90217 Identical to #88339 except with a `.has_storage()` check before `.storage()`. ghstack-source-id: 179910561 Differential Revision: [D41737935](https://our.internmc.facebook.com/intern/diff/D41737935/)
|
@pytorchbot merge -f "unit test failures are preexisting" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Identical to #88339 except with a
.has_storage()check before.storage().Differential Revision: D41737935
cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @lezcano @Varal7