Fix torch.distributed.run init connect timeout by comparing host with the current IP list
#90221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cz-37
requested review from
mrshenli,
zhaojuanmao,
pritamdamania87,
rohan-varma,
H-Huang,
awgu,
kwen2501 and
wanchaol
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90221
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 20be3c6: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41373962 |
d4l3k
approved these changes
Dec 16, 2022
|
This pull request was exported from Phabricator. Differential Revision: D41373962 |
cz-37
force-pushed
the
export-D41373962
branch
from
319c179
to
bbcca7a
Compare
cz-37
added a commit
to cz-37/pytorch
that referenced
this pull request
Dec 19, 2022
…th the current IP list (pytorch#90221) Summary: Pull Request resolved: pytorch#90221 Pull Request: pytorch#79388 Fix torch.distributed.run init connect timeout by comparing `host` with the current IP list. Test Plan: ``` > buck2 test mode/dev-nosan //caffe2/test/distributed/elastic/rendezvous:utils_test -- --exact 'caffe2/test/distributed/elastic/rendezvous:utils_test - test_matches_machine_hostname_returns_true_if_ip_address_match_between_hosts (utils_test.UtilsTest)' Tests finished: Pass 1. Fail 0. Fatal 0. Skip 0. 0 builds failed ``` Unit tests Reviewed By: d4l3k Differential Revision: D41373962 fbshipit-source-id: 00e6c102ed920d8b91a9978b5fe7d3ed37b62584
…th the current IP list (pytorch#90221) Summary: Pull Request resolved: pytorch#90221 Pull Request: pytorch#79388 Fix torch.distributed.run init connect timeout by comparing `host` with the current IP list. Test Plan: ``` > buck2 test mode/dev-nosan //caffe2/test/distributed/elastic/rendezvous:utils_test -- --exact 'caffe2/test/distributed/elastic/rendezvous:utils_test - test_matches_machine_hostname_returns_true_if_ip_address_match_between_hosts (utils_test.UtilsTest)' Tests finished: Pass 1. Fail 0. Fatal 0. Skip 0. 0 builds failed ``` Unit tests Reviewed By: d4l3k Differential Revision: D41373962 fbshipit-source-id: 7f138e2ef74b057f70271d32b605710bc5d287f6
cz-37
force-pushed
the
export-D41373962
branch
from
bbcca7a
to
20be3c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41373962 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Pull Request: #79388
Fix torch.distributed.run init connect timeout by comparing
hostwith the current IP list.Test Plan: unit tests
Differential Revision: D41373962