[fx][passes] Implement annotate getitem node FX passes #90237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90237
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 06b703d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41749744 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41749744 |
lequytra
added a commit
to lequytra/pytorch
that referenced
this pull request
Dec 6, 2022
Summary: Pull Request resolved: pytorch#90237 One common cause of jit unscriptability issue is loss of node type annotations on local names after one or several FX transform(s). One way to improve the type coverage is to eagerly annotate the type for `getitem` nodes from its parent sequence node. This diff introduces an fx pass to do that. Test Plan: ``` buck2 test //caffe2/test:fx_experimental ``` Reviewed By: xush6528 Differential Revision: D41749744 fbshipit-source-id: 4806628cb7e2ef847fc5132aa1b054313359e332
lequytra
force-pushed
the
export-D41749744
branch
from
43124ab
to
3577cc5
Compare
Summary: Pull Request resolved: pytorch#90237 One common cause of jit unscriptability issue is loss of node type annotations on local names after one or several FX transform(s). One way to improve the type coverage is to eagerly annotate the type for `getitem` nodes from its parent sequence node. This diff introduces an fx pass to do that. Test Plan: ``` buck2 test //caffe2/test:fx_experimental ``` Reviewed By: xush6528 Differential Revision: D41749744 fbshipit-source-id: ba1dbe4e19cf1d2ee4ccaf81176bac7e293fd2ce
lequytra
force-pushed
the
export-D41749744
branch
from
3577cc5
to
06b703d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41749744 |
xush6528
approved these changes
Dec 6, 2022
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
Summary: One common cause of jit unscriptability issue is loss of node type annotations on local names after one or several FX transform(s). One way to improve the type coverage is to eagerly annotate the type for `getitem` nodes from its parent sequence node. This diff introduces an fx pass to do that. Test Plan: ``` buck2 test //caffe2/test:fx_experimental ``` Reviewed By: xush6528 Differential Revision: D41749744 Pull Request resolved: pytorch#90237 Approved by: https://github.com/xush6528
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: One common cause of jit unscriptability issue is loss of node type annotations on local names after one or several FX transform(s). One way to improve the type coverage is to eagerly annotate the type for
getitemnodes from its parent sequence node. This diff introduces an fx pass to do that.Test Plan:
Reviewed By: xush6528
Differential Revision: D41749744