[fx] Have replace_pattern return replaced nodes #90244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90244
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit f73fc37: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
angelayi
added a commit
to angelayi/pytorch
that referenced
this pull request
Dec 7, 2022
Summary: Pull Request resolved: pytorch#90244 Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (`List[Tuple[Match, List[Node]]]`). This allows us to easily modify the replaced nodes, including setting the metadata. Test Plan: CI Reviewed By: SherlockNoMad Differential Revision: D41737056 fbshipit-source-id: 0091c3d9177c64685e597902513fbbdc0b625b0c
angelayi
force-pushed
the
export-D41737056
branch
from
2ba6b59
to
ab5c1b4
Compare
angelayi
added a commit
to angelayi/pytorch
that referenced
this pull request
Dec 7, 2022
Summary: Pull Request resolved: pytorch#90244 Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (`List[Tuple[Match, List[Node]]]`). This allows us to easily modify the replaced nodes, including setting the metadata. Test Plan: CI Reviewed By: SherlockNoMad Differential Revision: D41737056 fbshipit-source-id: f58ecd9db2c438be6c5402633ff272024665d750
angelayi
force-pushed
the
export-D41737056
branch
from
ab5c1b4
to
f5d80ff
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
angelayi
added a commit
to angelayi/pytorch
that referenced
this pull request
Dec 7, 2022
Summary: Pull Request resolved: pytorch#90244 Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (`List[Tuple[Match, List[Node]]]`). This allows us to easily modify the replaced nodes, including setting the metadata. Test Plan: CI Reviewed By: SherlockNoMad Differential Revision: D41737056 fbshipit-source-id: da78e06c4aec8a3024182bfa486aa553c665d938
angelayi
force-pushed
the
export-D41737056
branch
from
f5d80ff
to
0c73413
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
angelayi
added a commit
to angelayi/pytorch
that referenced
this pull request
Dec 7, 2022
Summary: Pull Request resolved: pytorch#90244 Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (`List[Tuple[Match, List[Node]]]`). This allows us to easily modify the replaced nodes, including setting the metadata. Test Plan: CI Reviewed By: SherlockNoMad Differential Revision: D41737056 fbshipit-source-id: bfa5b47cdb59503b6a1531afa8dc5aebf377b448
angelayi
force-pushed
the
export-D41737056
branch
from
0c73413
to
39a6d49
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
angelayi
force-pushed
the
export-D41737056
branch
from
39a6d49
to
3200ddc
Compare
angelayi
added a commit
to angelayi/pytorch
that referenced
this pull request
Dec 8, 2022
Summary: Pull Request resolved: pytorch#90244 Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (`List[Tuple[Match, List[Node]]]`). This allows us to easily modify the replaced nodes, including setting the metadata. Test Plan: CI Reviewed By: SherlockNoMad Differential Revision: D41737056 fbshipit-source-id: 3b73a2b488b7b5074e533f4e42ec0d61c0a8f74a
Summary: Pull Request resolved: pytorch#90244 Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (`List[Tuple[Match, List[Node]]]`). This allows us to easily modify the replaced nodes, including setting the metadata. Test Plan: CI Reviewed By: SherlockNoMad Differential Revision: D41737056 fbshipit-source-id: 5f3a9f9be06d9df4edd11698b379c86a9a290ed5
|
This pull request was exported from Phabricator. Differential Revision: D41737056 |
angelayi
force-pushed
the
export-D41737056
branch
from
3200ddc
to
f73fc37
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Modified replace_pattern in the subgraph rewriter to return a list of pairs of matches along with their corresponding replacement nodes in the modified graph (
List[Tuple[Match, List[Node]]]). This allows us to easily modify the replaced nodes, including setting the metadata.Test Plan: CI
Differential Revision: D41737056