Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MPS] Fix median_out_mps caching #90326

Closed
wants to merge 3 commits into from
Closed

[MPS] Fix median_out_mps caching #90326

wants to merge 3 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Dec 6, 2022

We should cache graph based on input tensor type

Fixes #90311

We should cache graph based on input tensor type

Fixes #90311
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 6, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90326

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ef28116:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 6, 2022
@malfet
Copy link
Contributor Author

malfet commented Dec 6, 2022

@pytorchbot merge -f "MPS tests are green"

@malfet malfet added the topic: bug fixes topic category label Dec 6, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@malfet
Copy link
Contributor Author

malfet commented Dec 7, 2022

@pytorchmergebot revert -m "Modified wrong key" -c weird

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@malfet your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Dec 7, 2022
This reverts commit 23c192c.

Reverted #90326 on behalf of https://github.com/malfet due to Modified wrong key
@malfet malfet reopened this Dec 7, 2022
@malfet
Copy link
Contributor Author

malfet commented Dec 7, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 7, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
We should cache graph based on input tensor type

Fixes pytorch#90311

Pull Request resolved: pytorch#90326
Approved by: https://github.com/kulinseth
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
This reverts commit 23c192c.

Reverted pytorch#90326 on behalf of https://github.com/malfet due to Modified wrong key
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
We should cache graph based on input tensor type

Fixes pytorch#90311

Pull Request resolved: pytorch#90326
Approved by: https://github.com/kulinseth
@malfet malfet deleted the malfet-patch-9 branch January 20, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category Reverted topic: bug fixes topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MPS] test_median fails on Ventura
3 participants