Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPA] Fix alignment check for efficient_attention #90413

Closed
wants to merge 8 commits into from

Conversation

drisspg
Copy link
Contributor

@drisspg drisspg commented Dec 7, 2022

Fixes a bug found using head_dim_size==100 on an a100 gpu. This PR contains stricter guards on the input shape. These constraints are taken from xformers: https://github.com/facebookresearch/xformers/blob/gh/danthe3rd/60/orig/xformers/ops/fmha/cutlass.py#L23

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 7, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90413

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 1c7bc96:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@drisspg drisspg marked this pull request as ready for review December 7, 2022 22:04
@drisspg drisspg requested a review from cpuhrsch December 7, 2022 22:04
@drisspg drisspg changed the title alignment value should be 8 for sm75+ 16bit types [SDP] Fix alignment check for efficient_attention Dec 7, 2022
@pytorch pytorch deleted a comment from pytorch-bot bot Dec 7, 2022
@drisspg
Copy link
Contributor Author

drisspg commented Dec 7, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 7, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@drisspg
Copy link
Contributor Author

drisspg commented Dec 9, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@drisspg
Copy link
Contributor Author

drisspg commented Dec 9, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #90413, but it was already up to date

@drisspg
Copy link
Contributor Author

drisspg commented Dec 9, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Tried to rebase and push PR #90413, but it was already up to date

@drisspg
Copy link
Contributor Author

drisspg commented Dec 9, 2022

@pytorchbot merge -f "unrelated to my changes"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@drisspg drisspg changed the title [SDP] Fix alignment check for efficient_attention [SDPA] Fix alignment check for efficient_attention Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: multi-headed-attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants