Add support to foreach torch.zero for bfloat16s #90437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90437
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 2272b79: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
soumith
approved these changes
Dec 8, 2022
drisspg
changed the title
|
@pytorchbot merge -f "distributed failures are unrelated to my change" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
# Summary When training a model with SGD(..., foreach=true) found that bfloat16 model was erroring with no cuda support for empty. Pull Request resolved: pytorch#90437 Approved by: https://github.com/soumith
ngimel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When training a model with SGD(..., foreach=true) found that bfloat16 model was erroring with no cuda support for empty.