[ao] making _is_activation_post_process private with BC #90554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 175562238 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
requested review from
jerryzh168,
z-a-f,
albanD and
anjali411
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90554
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 993c87e: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
HDCharles
added a commit
that referenced
this pull request
Dec 9, 2022
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 175562238 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! ghstack-source-id: 175672317 Pull Request resolved: #90554
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 9, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 175696027 ghstack-source-id: 175696027 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 12, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 175897293 ghstack-source-id: 175897293 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 12, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 175904400 ghstack-source-id: 175904400 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 13, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 175958921 ghstack-source-id: 175958921 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 13, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 176034427 ghstack-source-id: 176034427 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 13, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 176052560 ghstack-source-id: 176052560 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 14, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 176078174 ghstack-source-id: 176078174 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 14, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 176086032 ghstack-source-id: 176086032 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 15, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 176191354 ghstack-source-id: 176191354 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 15, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 41612ed16bc00e220d0efc4eef28c6c7e8ab2aaf ghstack-source-id: 41612ed16bc00e220d0efc4eef28c6c7e8ab2aaf Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 15, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 5a501a047683136aa6e7cca01229c47262c52354 ghstack-source-id: 5a501a047683136aa6e7cca01229c47262c52354 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)!
|
@HDCharles has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 16, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 176313891 ghstack-source-id: 176313891 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/)
same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D41793604/)! [ghstack-poisoned]
HDCharles
added a commit
that referenced
this pull request
Dec 16, 2022
Pull Request resolved: #90554 same function in observer and quantize, consolidated to a single function note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name ghstack-source-id: 176320690 ghstack-source-id: 176320690 Differential Revision: [D41793604](https://our.internmc.facebook.com/intern/diff/D41793604/)
|
@pytorchmergebot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
same function in observer and quantize, consolidated to a
single function
note: this is a recreation of D40709276 which caused severa breakages due to not maintaining BC for models with cached code with calls to the old function name
Differential Revision: D41793604
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!