Fix unconvertible_ops as per #89261 (#89299) #90684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pytorch#89261 Pull Request resolved: pytorch#89299 Approved by: https://github.com/justinchuby, https://github.com/BowenBao
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90684
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bde580d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: onnx
|
It does not look like test is fixing the regression, see #89299 (comment) |
|
@malfet I have cherry-picked the additional commit merged today to master branch that fixes the test case. Do you want to reopen this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89261
Pull Request resolved: #89299
Approved by: https://github.com/justinchuby, https://github.com/BowenBao