Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] fix hipify mapping for cuDeviceGet #90726

Closed
wants to merge 1 commit into from
Closed

[ROCm] fix hipify mapping for cuDeviceGet #90726

wants to merge 1 commit into from

Conversation

jeffdaily
Copy link
Collaborator

@jeffdaily jeffdaily commented Dec 12, 2022 •
edited by pytorch-bot bot

The mapping was incorrect, but only certain downstream pytorch extensions found this issue. pytorch CI does not cover this mapping.

cc @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90726

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 43f8fc6:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: rocm AMD GPU support for Pytorch label Dec 12, 2022
@jeffdaily jeffdaily added rocm This tag is for PRs from ROCm team rocm priority high priority ROCm PRs from performance or other aspects labels Dec 12, 2022
@pruthvistony pruthvistony added ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Dec 13, 2022
atalman
atalman approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffdaily jeffdaily removed ciflow/trunk Trigger trunk jobs on your pull request ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR labels Jan 6, 2023
@jeffdaily
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased rocm_hipify_mapping_cudeviceget onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout rocm_hipify_mapping_cudeviceget && git pull --rebase)

@jeffdaily
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 6, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@jeffdaily
Copy link
Collaborator Author

@pytorchbot merge -f "ignore rocm timeout"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

@pruthvistony pruthvistony pruthvistony approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: rocm AMD GPU support for Pytorch open source rocm priority high priority ROCm PRs from performance or other aspects rocm This tag is for PRs from ROCm team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jeffdaily @pytorchmergebot @atalman @pruthvistony @pytorchbot