Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Fix index_select scalar input with multiple indices #91064

Closed
wants to merge 1 commit into from
Closed

[MPS] Fix index_select scalar input with multiple indices #91064

wants to merge 1 commit into from

Conversation

qqaatw
Copy link
Collaborator

@qqaatw qqaatw commented Dec 17, 2022 •
edited by pytorch-bot bot

Support operations like this:

device="mps"
arr = torch.tensor(10, device=device)
indices = torch.tensor([0, 0], device=device)  # multiple indices 
torch.index_select(arr, 0, indices)

cc @kulinseth @albanD @malfet @DenisVieriu97 @razarmehr @abhudev

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 17, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91064

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures

As of commit cbdbae3:

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 17, 2022
@qqaatw
Copy link
Collaborator Author

qqaatw commented Dec 19, 2022

@pytorchbot label "module: mps"

@pytorch-bot pytorch-bot bot added the module: mps Related to Apple Metal Performance Shaders framework label Dec 19, 2022
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 21, 2022
@qqaatw qqaatw force-pushed the fix_index_select_scalar_input branch from 6e278be to 1ae97e2 Compare December 21, 2022 12:58
@qqaatw
Copy link
Collaborator Author

qqaatw commented Jan 10, 2023

Hello @kulinseth, can you please review this one?

@kulinseth
Copy link
Collaborator

Looks good.

@qqaatw
Copy link
Collaborator Author

qqaatw commented Jan 13, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 13, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@qqaatw qqaatw force-pushed the fix_index_select_scalar_input branch from 1ae97e2 to 2aa8adc Compare January 13, 2023 05:28
@qqaatw qqaatw force-pushed the fix_index_select_scalar_input branch from 2aa8adc to cbdbae3 Compare January 13, 2023 05:29
@qqaatw
Copy link
Collaborator Author

qqaatw commented Jan 13, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule MPS):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@qqaatw
Copy link
Collaborator Author

qqaatw commented Jan 13, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule MPS):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@qqaatw
Copy link
Collaborator Author

qqaatw commented Jan 19, 2023

@kulinseth @malfet Can you help merge this (or rerun the jobs)? The test failures are unrelated I think.

@kulinseth
Copy link
Collaborator

Right, the lint failure seems to be related to installation failure:

After this operation, 46.1 MB of additional disk space will be used.
Err:1 http://azure.archive.ubuntu.com/ubuntu focal/universe amd64 libxapian30 amd64 1.4.14-2
  Could not connect to azure.archive.ubuntu.com:80 (52.147.219.192), connection timed out
Err:2 http://azure.archive.ubuntu.com/ubuntu focal/universe amd64 doxygen amd64 1.8.17-0ubuntu2
  Unable to connect to azure.archive.ubuntu.com:http:
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/x/xapian-core/libxapian30_1.4.14-2_amd64.deb  Could not connect to azure.archive.ubuntu.com:80 (52.147.219.192), connection timed out
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/d/doxygen/doxygen_1.8.17-0ubuntu2_amd64.deb  Unable to connect to azure.archive.ubuntu.com:http:
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.

@kulinseth
Copy link
Collaborator

@pytorchbot merge -f "MPS tests are green."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: mps Related to Apple Metal Performance Shaders framework open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@qqaatw @kulinseth @pytorchmergebot @ngimel @pytorchbot