Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc improvement in LKJCholesky distribution #91091

Closed
wants to merge 4 commits into from

Conversation

felixdivo
Copy link
Contributor

@felixdivo felixdivo commented Dec 19, 2022

Better structure & formatting. Added more info to reference.

The change can be viewed here: https://docs-preview.pytorch.org/91091/distributions.html?highlight=lkjcholesky#torch.distributions.lkj_cholesky.LKJCholesky

Better structure & formatting. Added more info to reference.
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 19, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91091

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b014e4e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@felixdivo felixdivo changed the title Doc improvement in LKJCholesky distribution Draft: Doc improvement in LKJCholesky distribution Dec 19, 2022
@felixdivo felixdivo changed the title Draft: Doc improvement in LKJCholesky distribution Doc improvement in LKJCholesky distribution Dec 19, 2022
@kit1980
Copy link
Member

kit1980 commented Dec 20, 2022

@pytorchbot merge -f "Docstring change only"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: PR #91091 has not been reviewed yet (Rule Distributions)

Details for Dev Infra team Raised by workflow job

@kit1980
Copy link
Member

kit1980 commented Dec 20, 2022

@pytorchbot merge -f "Docstring change only"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants