Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Implement nan_to_num() for MPS backend #91110

Closed
wants to merge 3 commits into from
Closed

[MPS] Implement nan_to_num() for MPS backend #91110

wants to merge 3 commits into from

Conversation

razarmehr
Copy link
Collaborator

@razarmehr razarmehr commented Dec 19, 2022 •
edited by pytorch-bot bot

Added a test case, and also enabled it in TestConsistency

cc @kulinseth @albanD @malfet @DenisVieriu97 @abhudev

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 19, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91110

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 1 Pending

As of commit 48a4edd:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 19, 2022
@razarmehr razarmehr changed the title Implement nan_to_num() for MPS backend [MPS] Implement nan_to_num() for MPS backend Dec 19, 2022
@razarmehr razarmehr added the module: mps Related to Apple Metal Performance Shaders framework label Dec 19, 2022
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 21, 2022
@razarmehr
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@razarmehr @pytorchmergebot
Implement nan_to_num() for MPS backend
1a34133 
Added a test case, and also enabled it in TestConsistency
@pytorchmergebot
Copy link
Collaborator

Successfully rebased MPS_nan_to_num onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout MPS_nan_to_num && git pull --rebase)

malfet
malfet approved these changes Jan 4, 2023
View reviewed changes
aten/src/ATen/native/mps/operations/TensorCompare.mm Outdated Show resolved Hide resolved
aten/src/ATen/native/mps/operations/TensorCompare.mm Outdated Show resolved Hide resolved
razarmehr and others added 2 commits January 4, 2023 13:54
@razarmehr @malfet
Apply formatting suggestions
d569734 
Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
@razarmehr @malfet
Apply formatting suggestions
48a4edd 
Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
@razarmehr
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 4, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-py3.7-clang9-slow / build

Details for Dev Infra team Raised by workflow job

@razarmehr
Copy link
Collaborator Author

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@razarmehr razarmehr deleted the MPS_nan_to_num branch January 5, 2023 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@malfet malfet malfet approved these changes

@DenisVieriu97 DenisVieriu97 Awaiting requested review from DenisVieriu97

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged module: mps Related to Apple Metal Performance Shaders framework open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@razarmehr @pytorchmergebot @kulinseth @malfet @ngimel @pytorchbot