Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Fix data type issues in Unary ops #91120

Closed
wants to merge 4 commits into from
Closed

[MPS] Fix data type issues in Unary ops #91120

wants to merge 4 commits into from

Conversation

razarmehr
Copy link
Collaborator

@razarmehr razarmehr commented Dec 19, 2022 •
edited by pytorch-bot bot

Refactored sigmoid() and log1p()

cc @kulinseth @albanD @malfet @DenisVieriu97 @abhudev

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 19, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91120

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 47f3f97:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 19, 2022
@razarmehr razarmehr changed the title Fix data type issues in Unary ops [MPS] Fix data type issues in Unary ops Dec 19, 2022
@razarmehr razarmehr added module: mps Related to Apple Metal Performance Shaders framework and removed module: mps Related to Apple Metal Performance Shaders framework labels Dec 19, 2022
DenisVieriu97
DenisVieriu97 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@razarmehr
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 20, 2022
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'MPS'):
kulinseth, razarmehr, malfet, alband

Details for Dev Infra team Raised by workflow job

@razarmehr
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@razarmehr
Copy link
Collaborator Author

@pytorchbot merge -f "MPS tests are green."

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@DenisVieriu97 DenisVieriu97 DenisVieriu97 approved these changes

@malfet malfet Awaiting requested review from malfet

@albanD albanD Awaiting requested review from albanD

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@razarmehr @pytorchmergebot @kulinseth @DenisVieriu97 @pytorchbot