[Quant][FX] Lower QConvAddReLU2d for onednn backend #91155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91155
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d341248: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 20, 2022
This was referenced Dec 20, 2022
leslie-fang-intel
added a commit
that referenced
this pull request
Dec 20, 2022
ghstack-source-id: a250783bd6dd1a6827ddec0e7aaa19d224a7031c Pull Request resolved: #91155
leslie-fang-intel
changed the title
leslie-fang-intel
added
intel
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Dec 20, 2022
ghstack-source-id: 7d2e37a96cd34ba1e60875c1cb0d37f87daa886f Pull Request resolved: #91155
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Dec 20, 2022
ghstack-source-id: 323865436d6894e7d66c0916bff60eb032e75a31 Pull Request resolved: #91155
jgong5
reviewed
Dec 20, 2022
| for add_op in [torch.add, operator.add]: | ||
| conv_configs.append( | ||
| BackendPatternConfig() | ||
| ._set_pattern_complex_format((nn.ReLU, (add_op, nn.Conv2d, MatchAllNode))) |
There was a problem hiding this comment.
No, I will add it later. It's still WIP.
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Dec 20, 2022
ghstack-source-id: 10f8e3cc9bfc611e32b78d086c8d56b8e0337870 Pull Request resolved: #91155
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Dec 20, 2022
ghstack-source-id: 309f7ce0a9da89a3741c8553134fd48abfd4dad2 Pull Request resolved: #91155
cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
|
Hi @jerryzh168 Is there any other comments to this PR? Could you help to take a look again? |
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 26, 2023
ghstack-source-id: 1eb7579750f43db56c8df7da31fa4fecf62d62ff Pull Request resolved: #91155
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 26, 2023
ghstack-source-id: cda8be852745842f5b1145724b8fed34e2ede525 Pull Request resolved: #91155
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 27, 2023
ghstack-source-id: 33e9455ec5801cca7b50028be6bfdcfe33030131 Pull Request resolved: #91155
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 28, 2023
ghstack-source-id: 33f5ab8bc15723191d51178a02bfee41b011ea5f Pull Request resolved: #91155
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 28, 2023
ghstack-source-id: 09d048380b28a1b2c7659602a14c53166875962f Pull Request resolved: #91155
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 28, 2023
ghstack-source-id: 34f5bdf9f60e0259e12cdaaf35b8873435323a76 Pull Request resolved: #91155
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 28, 2023
ghstack-source-id: 7185ad799388d629cf13956af5bfda7a7ceba012 Pull Request resolved: #91155
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 28, 2023
ghstack-source-id: 2e793f3acb3946dba936e31065faadfed21a8c4d Pull Request resolved: #91155
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 30, 2023
ghstack-source-id: 01433833e5bae91266081f9b42b482839cb7e02c Pull Request resolved: #91155
|
Hi @jerryzh168, Could you also take a review of this PR again? |
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
**Summary** Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode. **Test plan** ``` python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_onednn python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_by_default python -m pytest test_quantization.py -k test_fuse_conv_bn_add_relu_lowering ``` cc jgong5 mingfeima XiaobingSuper sanchitintel ashokei jingxu10 [ghstack-poisoned]
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 31, 2023
ghstack-source-id: cdabb4cadbdd89647eca5cb60955697e2d6abd82 Pull Request resolved: #91155
leslie-fang-intel
added a commit
that referenced
this pull request
Jan 31, 2023
ghstack-source-id: b6c8340458034f576b172459a0c47abdaef6c431 Pull Request resolved: #91155
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
Add quantization mappings for QConvAddReLU2d for int8 inference for onednn backend. The fusion and lowering is supported only in FX mode.
Test plan
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10