Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProcessGroupRoundRobin #91172

Closed
wants to merge 1 commit into from
Closed

Conversation

H-Huang
Copy link
Member

@H-Huang H-Huang commented Dec 20, 2022

Summary:
Temporary fix to unblock jobs in https://fb.workplace.com/groups/300451907202972/permalink/906337097050850/

Real fix would be to remove use of _round_robin_process_group API and update corresponding references (e.g. PyText)

Test Plan: sandcastle

Differential Revision: D42169592

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 20, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91172

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit e580a66:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42169592

Summary:
Pull Request resolved: pytorch#91172

Temporary fix to unblock jobs in https://fb.workplace.com/groups/300451907202972/permalink/906337097050850/

Real fix would be to remove use of _round_robin_process_group API and update corresponding references (e.g. PyText)

Test Plan: sandcastle

Differential Revision: D42169592

fbshipit-source-id: 69b40e4d6f8da7727a0bf8bec80e5c8530f6fabc
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42169592

Copy link
Contributor

@awgu awgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 20, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: distributed (c10d) release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants