[Nested Tensor] do not use at::cuda::getDefaultCUDAStream(), again #91180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, Nested Tensor kernels won't sync with current stream, resulting in flaky unit tests in test_nestedtensor.py. This is the second time the wrong streams have been used in NestedTensor code. See pytorch#84134 for another example.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91180
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit 44f6d32: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Example CI run where this caused a failure for ROCm. https://hud.pytorch.org/pytorch/pytorch/commit/7330eabe3675e62d580b3c7d453b1f7f356e2c61 |
|
Thanks @jeffdaily for the fix, apologies for the wrong usage of getDefaultCUDAStream |
mikaylagawarecki
approved these changes
Dec 20, 2022
|
@pytorchbot merge -f "only failure due to offline ROCm runner" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, Nested Tensor kernels won't sync with current stream, resulting in flaky unit tests in test_nestedtensor.py.
This is the second time the wrong streams have been used in NestedTensor code. See #84134 for another example.