[MPS] Add suport for casting updatesTensor directly in scatter

[DenisVieriu97]

Fixes copies into slices where the input data type is different than the output dtype.

This change removes the cast done before scatter, so we don't have to allocate additional memory to perform the casting. Scatter handles the casting directly now.

device = "mps"
shape = (4, 4)
tensor = torch.randint(10, shape, device=device)
tensor_before = tensor.clone()
res = torch.empty(shape[0], shape[1] * 2, device=device)[:, ::2].copy_(tensor)
torch.testing.assert_close(tensor, tensor_before)

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91197

• 📄 Preview Python docs built from this PR
• 📄 Preview C++ docs built from this PR
• ❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 7bfcdf9:

FLAKY - The following jobs failed but were likely due to flakiness present on master:

• linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[razarmehr]

LGTM

[razarmehr]

@pytorchbot merge -g

[pytorchmergebot]

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

[pytorchmergebot]

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team

Raised by workflow job

[DenisVieriu97]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased add_cast_support_for_scatter onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_cast_support_for_scatter && git pull --rebase)

[DenisVieriu97]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased add_cast_support_for_scatter onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_cast_support_for_scatter && git pull --rebase)

[DenisVieriu97]

@pytorchbot merge -g

[pytorchmergebot]

Merge failed

Reason: Not merging any PRs at the moment because there is a merge blocking https://github.com/pytorch/pytorch/labels/ci:%20sev issue open at:
#91332

Details for Dev Infra team

Raised by workflow job

[DenisVieriu97]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased add_cast_support_for_scatter onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_cast_support_for_scatter && git pull --rebase)

[DenisVieriu97]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Tried to rebase and push PR #91197, but it was already up to date

[DenisVieriu97]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased add_cast_support_for_scatter onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_cast_support_for_scatter && git pull --rebase)

[DenisVieriu97]

@pytorchbot rebase

[pytorchmergebot]

@pytorchbot successfully started a rebase job. Check the current status here

[pytorchmergebot]

Successfully rebased add_cast_support_for_scatter onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout add_cast_support_for_scatter && git pull --rebase)

[DenisVieriu97]

@pytorchbot merge -f "Lint+MPS is green"

[pytorchmergebot]

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here