[MPS] Fix torch.std/torch.var default/correction handling
#91203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `torch.std`,`torch.var` are invoked without any arguments, it should be assumed that `unbiased` is `True`. Also, if `correction` parameter is specified it should be use in correction computation. Test by adding `std` and `var` to consistency tests
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91203
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e1c07f5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
kit1980
reviewed
Dec 21, 2022
| @@ -771,7 +770,7 @@ Tensor std_var_common_impl_mps( | |||
| name:nil]; | |||
| MPSGraphTensor *outputTensor; | |||
|
|
|||
| if (use_correction && correction_value) | |||
| if (correction_value) | |||
There was a problem hiding this comment.
The default for correction_value is 1, does this condition work as intended?
There was a problem hiding this comment.
Yes, that's the crux of a bugfix: default value for unbiased is True rather than false.
There was a problem hiding this comment.
Still bothers me a bit that now correction_value is an integer and it's not clear from the condition here and before.
It can only be 0 or 1?
There was a problem hiding this comment.
Nevermind, it was integer even before, false in const auto correction_value = use_correction ? correction.value() : false; was misleading.
There was a problem hiding this comment.
Exactly, one of the opinfo test even passes torch.var(x, correlation=2) and compares the CPU output.
kit1980
approved these changes
Dec 21, 2022
|
@pytorchbot merge -f "MPS tests are green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 21, 2022
Use Prims to implement group_norm, group_norm_backward and mean_var Use `torch._ops.ops` instead of `torch.ops` in numerous subpackages in order to be able to make them importable from `torch/backend/mps/__init__.py` as this alias is defined in https://github.com/pytorch/pytorch/blob/15af4b1ceea3b689354ad664675b930486804c8e/torch/__init__.py#L1095 is executed last during init process. Depends on #91203 Fixes #88331 Pull Request resolved: #91190 Approved by: https://github.com/albanD
malfet
added a commit
that referenced
this pull request
Dec 22, 2022
…mean_var`" Use Prims to implement group_norm, group_norm_backward and mean_var Use `torch._ops.ops` instead of `torch.ops` in numerous subpackages in order to be able to make them importable from `torch/backend/mps/__init__.py` as this alias is defined in https://github.com/pytorch/pytorch/blob/15af4b1ceea3b689354ad664675b930486804c8e/torch/__init__.py#L1095 is executed last during init process. Depends on #91203 Fixes #88331 [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Dec 22, 2022
Use Prims to implement group_norm, group_norm_backward and mean_var Use `torch._ops.ops` instead of `torch.ops` in numerous subpackages in order to be able to make them importable from `torch/backend/mps/__init__.py` as this alias is defined in https://github.com/pytorch/pytorch/blob/15af4b1ceea3b689354ad664675b930486804c8e/torch/__init__.py#L1095 is executed last during init process. Depends on #91203 Fixes #88331 [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Dec 22, 2022
…mean_var` (take 2)" Use Prims to implement group_norm, group_norm_backward and mean_var Use `torch._ops.ops` instead of `torch.ops` in numerous subpackages in order to be able to make them importable from `torch/backend/mps/__init__.py` as this alias is defined in https://github.com/pytorch/pytorch/blob/15af4b1ceea3b689354ad664675b930486804c8e/torch/__init__.py#L1095 is executed last during init process. Depends on #91203 Fixes #88331 [ghstack-poisoned]
malfet
added a commit
that referenced
this pull request
Dec 22, 2022
Use Prims to implement group_norm, group_norm_backward and mean_var Use `torch._ops.ops` instead of `torch.ops` in numerous subpackages in order to be able to make them importable from `torch/backend/mps/__init__.py` as this alias is defined in https://github.com/pytorch/pytorch/blob/15af4b1ceea3b689354ad664675b930486804c8e/torch/__init__.py#L1095 is executed last during init process. Depends on #91203 Fixes #88331 [ghstack-poisoned]
ShisuiUzumaki
pushed a commit
to ShisuiUzumaki/pytorch
that referenced
this pull request
Dec 23, 2022
Use Prims to implement group_norm, group_norm_backward and mean_var Use `torch._ops.ops` instead of `torch.ops` in numerous subpackages in order to be able to make them importable from `torch/backend/mps/__init__.py` as this alias is defined in https://github.com/pytorch/pytorch/blob/15af4b1ceea3b689354ad664675b930486804c8e/torch/__init__.py#L1095 is executed last during init process. Depends on pytorch#91203 Fixes pytorch#88331 Pull Request resolved: pytorch#91190 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
torch.std,torch.varare invoked without any arguments, it should be assumed thatunbiasedisTrue.Also, if
correctionparameter is specified it should be use in correction computation.Test by adding
stdandvarto consistency testsFixes #91198