Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkpoint] Update docstring for DCP save_state_dict and load_state_dict #91209

Closed
wants to merge 4 commits into from
Closed

[Checkpoint] Update docstring for DCP save_state_dict and load_state_dict #91209

wants to merge 4 commits into from

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Dec 20, 2022

As title.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 20, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91209

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6f78cc0:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 marked this pull request as ready for review December 20, 2022 22:37
@wz337 wz337 requested a review from fduwjj December 20, 2022 22:37
@wz337 wz337 changed the title [Checkpoint] Update docstring for save_state_dict and load_state_dict [Checkpoint] Update docstring for DCP save_state_dict and load_state_dict Dec 20, 2022
fduwjj
fduwjj approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and leave some comments.

torch/distributed/checkpoint/state_dict_loader.py Outdated
@@ -22,34 +22,39 @@ def load_state_dict(
planner: LoadPlanner = None,
) -> None:
"""
Load a distributed state_dict in SPMD style.
Loads a distributed state_dict in SPMD style.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: ``state_dict``

torch/distributed/checkpoint/state_dict_loader.py Outdated

When loading ShardedTensor instances, each rank only
reads data for their local shards.
to fullfill the requested `state_dict`. When loading ShardedTensor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:class:`ShardedTensor`

@wz337
Copy link
Contributor Author

wz337 commented Dec 22, 2022

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 22, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu) ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@wz337
Copy link
Contributor Author

wz337 commented Dec 22, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased update_state_dict_saver_loader_docstring onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_state_dict_saver_loader_docstring && git pull --rebase)

@wz337
Copy link
Contributor Author

wz337 commented Dec 22, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ShisuiUzumaki pushed a commit to ShisuiUzumaki/pytorch that referenced this pull request Dec 23, 2022
@wz337 @ShisuiUzumaki
[Checkpoint] Update docstring for DCP save_state_dict and ``load_…
8296324 
…state_dict`` (pytorch#91209)

As title.
Pull Request resolved: pytorch#91209
Approved by: https://github.com/fduwjj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wz337 @pytorchmergebot @fduwjj