Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support indices contiguity per batch and non-contiguous values in sparse compressed tensors #91243

Closed
wants to merge 13 commits into from
Closed

Support indices contiguity per batch and non-contiguous values in sparse compressed tensors #91243

wants to merge 13 commits into from

Conversation

pearu
Copy link
Collaborator

@pearu pearu commented Dec 21, 2022 •
edited

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).

Stack from ghstack (oldest at bottom):

cc @nikitaved @cpuhrsch @amjames @bhosmer

@pearu pearu requested a review from a team as a code owner December 21, 2022 12:04
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 21, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91243

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7f70a0c:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Dec 21, 2022
@pearu pearu mentioned this pull request Dec 21, 2022
Closed
@pearu pearu added module: sparse Related to torch.sparse open source labels Dec 21, 2022
@pearu pearu added this to In progress in Sparse tensors via automation Dec 21, 2022
@pearu pearu self-assigned this Dec 21, 2022
@pearu pearu changed the title Support non-contiguous inputs in validation of sparse compressed tensors Support indices contiguity per batch and non-contiguous values in sparse compressed tensors Dec 21, 2022
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
10c448c 
…lues in sparse compressed tensors"

Fixes #91062




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
6c1c17e 
…lues in sparse compressed tensors"

Fixes #91062




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu pearu mentioned this pull request Dec 21, 2022
Closed
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
629a32b 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu pearu mentioned this pull request Dec 22, 2022
Closed
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
7929a18 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
47cc9c2 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
44bcf20 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
6eefb37 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu pearu requested a review from nikitaved December 27, 2022 21:46
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
b7975b0 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
a3ebbb2 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu pearu requested a review from nikitaved December 28, 2022 12:20
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
c139a92 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@pearu pearu requested a review from nikitaved December 28, 2022 20:06
@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
9d606a2 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
nikitaved
nikitaved approved these changes Dec 29, 2022
View reviewed changes
Copy link
Collaborator

@nikitaved nikitaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @pearu !

Sparse tensors automation moved this from In progress to Reviewer approved Dec 29, 2022
@pearu
Copy link
Collaborator Author

pearu commented Dec 29, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 29, 2022
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
YXIE14, 842974287, terrychenism, fuqianz, Xirider, ...

Details for Dev Infra team Raised by workflow job

@pearu
Copy link
Collaborator Author

pearu commented Dec 29, 2022

@YXIE14, @842974287, @terrychenism, @fuqianz, or @Xirider , could you approve this PR? Thanks!

@pearu
Update on "Support indices contiguity per batch and non-contiguous va…
7f70a0c 
…lues in sparse compressed tensors"

Fixes #91062

With this PR, all reported failures in #90849 are resolved (modulo test_bmm that uses an unorthodox way to construct a batch CSR tensor).




cc nikitaved cpuhrsch amjames bhosmer

[ghstack-poisoned]
@amjames
Copy link
Collaborator

amjames commented Jan 2, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
wanchaol, wenleix, smeenai, l-kirsch, mortzur, ...

Details for Dev Infra team Raised by workflow job

@lezcano
Copy link
Collaborator

lezcano commented Jan 2, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sparse tensors automation moved this from Reviewer approved to Done Jan 2, 2023
@pearu pearu mentioned this pull request Jan 3, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/pearu/84/head branch June 8, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitaved nikitaved nikitaved approved these changes

@lezcano lezcano lezcano approved these changes

@amjames amjames amjames approved these changes

Assignees

@pearu pearu

Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: sparse Related to torch.sparse open source release notes: sparse release notes category
Projects
Sparse tensors
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pearu @pytorchmergebot @amjames @lezcano @nikitaved