Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkpoint] Update DCP init to include DefaultSavePlanner/DefaultLoadPlanner #91269

Closed
wants to merge 1 commit into from
Closed

[Checkpoint] Update DCP init to include DefaultSavePlanner/DefaultLoadPlanner #91269

wants to merge 1 commit into from

Conversation

wz337
Copy link
Contributor

@wz337 wz337 commented Dec 21, 2022 •
edited

Adding the two APIs to dcp package __init__.py, as users are recommended to extend DefaultSavePlanner/DefaultLoadPlanner instead of the planner interface directly.

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 21, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91269

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 99ff602:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 marked this pull request as ready for review December 21, 2022 21:19
@wz337 wz337 requested a review from fduwjj December 21, 2022 21:19
fduwjj
fduwjj approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wz337
Copy link
Contributor Author

wz337 commented Dec 22, 2022

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 22, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 3 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu) ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@wz337
Copy link
Contributor Author

wz337 commented Dec 22, 2022

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased update_dcp_init onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_dcp_init && git pull --rebase)

@wz337
Copy link
Contributor Author

wz337 commented Dec 22, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ShisuiUzumaki pushed a commit to ShisuiUzumaki/pytorch that referenced this pull request Dec 23, 2022
@wz337 @ShisuiUzumaki
[Checkpoint] Update DCP init to include DefaultSavePlanner/DefaultLoa…
b8bf7ba 
…dPlanner (pytorch#91269)

Adding the two APIs to dcp package `__init__.py`, as users are recommended to extend DefaultSavePlanner/DefaultLoadPlanner instead of the planner interface directly.
Pull Request resolved: pytorch#91269
Approved by: https://github.com/fduwjj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fduwjj fduwjj fduwjj approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@pritamdamania87 pritamdamania87 Awaiting requested review from pritamdamania87

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wz337 @pytorchmergebot @fduwjj