Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dtype mismatch for unallocated storage deserialization #91285

Closed
wants to merge 1 commit into from
Closed

Fix dtype mismatch for unallocated storage deserialization #91285

wants to merge 1 commit into from

Conversation

kurtamohler
Copy link
Collaborator

@kurtamohler kurtamohler commented Dec 22, 2022 •
edited by pytorch-bot bot

Fixes #90497

cc @mruberry

@kurtamohler kurtamohler added the module: serialization Issues related to serialization (e.g., via pickle, or otherwise) of PyTorch objects label Dec 22, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 22, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91285

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 3725686:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kurtamohler kurtamohler force-pushed the fix-unallocated-serialization-dtype-90497 branch from 19b7209 to fd3f68d Compare December 22, 2022 00:30
@mruberry mruberry requested a review from ezyang December 22, 2022 17:07
@mruberry
Copy link
Collaborator

@ezyang I think you might want to check this?

@drisspg drisspg added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Dec 22, 2022
ezyang
ezyang approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This special case is just... lol

@kurtamohler
Copy link
Collaborator Author

Yeah, I think when I do #91325 I'll hopefully be able to make the serialization code a little less insane

@kurtamohler
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 23, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64 / test (default, 2, 2, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@kurtamohler kurtamohler force-pushed the fix-unallocated-serialization-dtype-90497 branch from fd3f68d to 3725686 Compare December 24, 2022 00:07
@kurtamohler
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@kurtamohler
Copy link
Collaborator Author

@pytorchbot merge -f "unrelated failure"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@pmeier pmeier Awaiting requested review from pmeier

@mruberry mruberry Awaiting requested review from mruberry

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: serialization Issues related to serialization (e.g., via pickle, or otherwise) of PyTorch objects open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Saving and loading unallocated storage and tensor at the same time can result in incorrect dtype
6 participants
@kurtamohler @mruberry @pytorchmergebot @ezyang @pytorchbot @drisspg