Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Add @pytorch in tools/bazel.bzl #91424

Closed
wants to merge 1 commit into from

Conversation

vors
Copy link
Contributor

@vors vors commented Dec 27, 2022

This is a follow-up from #89660
There is another place that needs to be updated.

I think this time I covered all of them...

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 27, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91424

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9a00cad:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 27, 2022
@zou3519 zou3519 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 4, 2023
@zou3519 zou3519 requested a review from a team January 4, 2023 15:08
@malfet malfet added topic: improvements topic category topic: build release notes: build release notes category and removed topic: not user facing topic category topic: build labels Jan 4, 2023
@malfet
Copy link
Contributor

malfet commented Jan 4, 2023

@pytorchbot merge -f "Bazel builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

razarmehr pushed a commit to kulinseth/pytorch that referenced this pull request Jan 4, 2023
This is a follow-up from pytorch#89660
There is another place that needs to be updated.

I think this time I covered all of them...
Pull Request resolved: pytorch#91424
Approved by: https://github.com/malfet
@dagitses
Copy link
Collaborator

dagitses commented Jan 4, 2023

What are the edge cases under which // resolves to the top-level workspace?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merged open source release notes: build release notes category topic: improvements topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants