Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to skip loading of debug traces #91430

Closed
wants to merge 1 commit into from
Closed

Add an option to skip loading of debug traces #91430

wants to merge 1 commit into from

Conversation

qihqi
Copy link
Contributor

@qihqi qihqi commented Dec 28, 2022

Summary:
Debug traces consumes lots of memory especially for small models.

Test Plan:
Unit test

Reviewers:

Subscribers:

Tasks:

Tags:

Fixes #ISSUE_NUMBER

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Dec 28, 2022
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 28, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91430

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c09731a:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

davidberard98
davidberard98 approved these changes Dec 28, 2022
View reviewed changes
Copy link
Contributor

@davidberard98 davidberard98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

also interesting, I haven't seen the caffe2/serialize code before. Interesting that it's in caffe2/ instead of torch/csrc/. I guess maybe that logic is shared with caffe2?

caffe2/serialize/inline_container.cc Outdated
@@ -1,3 +1,4 @@
#include <iostream>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: stray debug? or I might have missed where it is used

@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@qihqi
Add an option to skip loading of debug traces
c09731a 
Summary:
Debug traces consumes lots of memory especially for small models.

Test Plan:
Unit test

Reviewers:

Subscribers:

Tasks:

Tags:
@facebook-github-bot
Copy link
Contributor

@qihqi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@qihqi
Copy link
Contributor Author

qihqi commented Dec 29, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 29, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidberard98 davidberard98 davidberard98 approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: jit release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qihqi @facebook-github-bot @pytorchmergebot @davidberard98