Avoid calling allclose in the backward if there are tensor subclasses #91444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`allclose` it's data-dependent (returns a bool) so it does not play well with functorch. We are skipping that check in the context of subclasses to avoid hard errors. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91444
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit cbb629d: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lezcano
added a commit
that referenced
this pull request
Dec 28, 2022
`allclose` it's data-dependent (returns a bool) so it does not play well with functorch. We are skipping that check in the context of subclasses to avoid hard errors. ghstack-source-id: 43e9d6e23047be7c6fed4198ea32408531dc7688 Pull Request resolved: #91444
lezcano
added
module: functorch
… subclasses" `allclose` it's data-dependent (returns a bool) so it does not play well with functorch. We are skipping that check in the context of subclasses to avoid hard errors. Partially fixes #90499 cc zou3519 Chillee samdow soumith [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Dec 28, 2022
`allclose` it's data-dependent (returns a bool) so it does not play well with functorch. We are skipping that check in the context of subclasses to avoid hard errors. ghstack-source-id: cc6278acefadb56f61e946f3764f4675274cbd9b Pull Request resolved: #91444
|
@pytorchbot merge -f "unrelated error" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
allcloseit's data-dependent (returns a bool) so it does not play wellwith functorch. We are skipping that check in the context of subclasses
to avoid hard errors.
Partially fixes #90499
cc @zou3519 @Chillee @samdow @soumith