Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Fix data type and shape issues in Scatter and Gather ops #91514

Closed
wants to merge 5 commits into from
Closed

[MPS] Fix data type and shape issues in Scatter and Gather ops #91514

wants to merge 5 commits into from

Conversation

razarmehr
Copy link
Collaborator

  • Clean up redundant code and headers
  • Move scatter/gather ops from block list to allow list in TestConsistency

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 29, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91514

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 35ca2e3:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Dec 29, 2022
@H-Huang H-Huang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 3, 2023
@kulinseth
Copy link
Collaborator

@pytorchbot merge

@kulinseth
Copy link
Collaborator

@pytorchbot help

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'help' (choose from 'merge', 'revert', 'rebase', 'label', 'drci')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@kulinseth
Copy link
Collaborator

@pytorchbot merge --help

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 4, 2023

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: --help

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci} ...

Try @pytorchbot --help for more info.

@kulinseth
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 4, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR is too stale; the last push date was more than 3 days ago. Please rebase and try again. You can rebase by leaving the following comment on this PR:
@pytorchbot rebase

Details for Dev Infra team Raised by workflow job

@razarmehr
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@razarmehr @pytorchmergebot
Fix the cast and shape issues with Scatter and Gather ops (#174)
88aa616 
- check for numel()==0 for input tensors
- clean up duplicate and redundant code and headers
- move some ops from block list to allow list
@razarmehr @pytorchmergebot
Fix cast issue in scatter() with uint8 type (#178)
561ab9b 
* Fix cast issue in scatter() with uint8 type
Also fix float16 for scatter_add()

* Remove the redundant line in scatter()
@razarmehr @pytorchmergebot
Fix Bool type issue in gather() for Monterey
907794a
@razarmehr @pytorchmergebot
Pass exisiting input_shape to Placeholder
b1117f4
@razarmehr @pytorchmergebot
Fix the Bool type failure with Scatter in Monterey
35ca2e3
@pytorchmergebot
Copy link
Collaborator

Successfully rebased MPS_scatter_gather_fixes onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout MPS_scatter_gather_fixes && git pull --rebase)

@razarmehr
Copy link
Collaborator Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@razarmehr
Copy link
Collaborator Author

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

@malfet malfet Awaiting requested review from malfet

@DenisVieriu97 DenisVieriu97 Awaiting requested review from DenisVieriu97

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@razarmehr @kulinseth @pytorchmergebot @H-Huang @pytorchbot