Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update vmap to accept nones #91644

Closed
wants to merge 7 commits into from
Closed

update vmap to accept nones #91644

wants to merge 7 commits into from

Conversation

srossross
Copy link
Collaborator

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 3, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91644

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures

As of commit 86e48a6:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@srossross srossross added the release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch label Jan 3, 2023
@srossross srossross marked this pull request as ready for review January 3, 2023 22:31
@mikaylagawarecki mikaylagawarecki added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 6, 2023
kshitij12345
kshitij12345 reviewed Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add support for returning unbatched tensor and a test for the same.

torch/_functorch/vmap.py Outdated Show resolved Hide resolved
torch/_functorch/vmap.py Outdated Show resolved Hide resolved
torch/_functorch/vmap.py Outdated Show resolved Hide resolved
torch/_functorch/vmap.py Outdated Show resolved Hide resolved
kshitij12345
kshitij12345 approved these changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@kshitij12345 kshitij12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @srossross

Chillee
Chillee approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

@lezcano lezcano added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 19, 2023
@srossross
Copy link
Collaborator Author

@pytorchbot merge --force "Failures are not related to functorch"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Jan 23, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chillee Chillee Chillee approved these changes

@kshitij12345 kshitij12345 kshitij12345 approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: functorch release notes category; Pertaining to torch.func or pytorch/functorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vmap should be able to accept None in its out_dims argument vmap should support out_dims=None
7 participants
@srossross @pytorchmergebot @Chillee @kshitij12345 @lezcano @pytorchbot @mikaylagawarecki