-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MPS] Solve contiguos view tensors using arrayViews instead of blits (#146) #91743
[MPS] Solve contiguos view tensors using arrayViews instead of blits (#146) #91743
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91743
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 FailuresAs of commit f4d9f04: FLAKY - The following jobs failed but were likely due to flakiness present on master:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@pytorchbot rebase |
@pytorchbot successfully started a rebase job. Check the current status here |
Successfully rebased |
987217b
to
427c250
Compare
427c250
to
3ae33e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@pytorchbot rebase |
@pytorchbot successfully started a rebase job. Check the current status here |
* Solve contiguos view tensors using arrayViews instead of blit * Use c10::irange to iterate for loops * Remove additional space * Move the slicing of view tensors to View.mm
Successfully rebased |
3ae33e1
to
f4d9f04
Compare
@pytorchbot merge -g |
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu) Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -f "Lint+MPS is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Solve contiguous view tensors using arrayViews directly instead of performing blit or gather.
E.g in case of the following example:
Previously,
y
would be materialized using a gather or a blit. With this change, the memory ofy
is aliased directly using arrayViews, thus skipping the need for blit or gather.Fixes #85297, #86048