New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JIT] Skip builtins while enumerating class methods #91805
Conversation
This is needed to support `enum.Enum` derived classes in Python-3.11 that adds `_new_member_` to classdict, see: https://github.com/python/cpython/blob/15c44789bb125b93e96815a336ec73423c47508e/Lib/enum.py#L529 Following snippet illustrates the problem with the previous iteration of the code on 3.11: ```python from enum import Enum import inspect class Color(Enum): RED = 1 GREEN = 2 def print_routines(cls): print(cls.__name__) for name in cls.__dict__: fn = getattr(cls, name) if inspect.isroutine(fn): print(name, fn, f"has_globals: {hasattr(fn, '__globals__')}") print_routines(Color) ```
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91805
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cda01cd: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Depends on #91805 Fixes #85506 Pull Request resolved: #91825 Approved by: https://github.com/albanD
This is needed to support
enum.Enum
derived classes in Python-3.11that adds
_new_member_
to classdict, see:https://github.com/python/cpython/blob/15c44789bb125b93e96815a336ec73423c47508e/Lib/enum.py#L529
Following snippet illustrates the problem with the previous iteration of
the code on 3.11: