Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Fix convolution `Source and weight input channels mismatch' crash #91822

Closed
wants to merge 6 commits into from
Closed

[MPS] Fix convolution `Source and weight input channels mismatch' crash #91822

wants to merge 6 commits into from

Conversation

DenisVieriu97
Copy link
Collaborator

Fixes crashes in conv input/weight backward passes due to NCHW / NHWC formats.

@DenisVieriu97 DenisVieriu97 added the ciflow/mps Run MPS tests (subset of trunk) label Jan 6, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 6, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91822

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit 0f383fc:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: mps Release notes category label Jan 6, 2023
razarmehr
razarmehr approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

DenisVieriu97 and others added 6 commits January 9, 2023 18:07
@DenisVieriu97 @pytorchmergebot
Convert grad output always to NCHW in mps_convolution_backward_input (#…
8b4c664 
…190)

* Convert grad output always to NCHW in mps_convolution_backward_input

* Fix grad_input shape in backward convolution
@DenisVieriu97 @pytorchmergebot
Add more testcases for convolution backward input pass (#191)
6e66bed
@DenisVieriu97 @kulinseth @pytorchmergebot
Fix conv grad weights (#192)
48bae0c 
* Fix conv gradient with weights when one input is contiguos and the other one is channels last

* Remove prints

* Fix the ConvGradient with weights for NHWC case. CLIP is now working.

Co-authored-by: Kulin Seth <kulin_seth@apple.com>
@DenisVieriu97 @pytorchmergebot
Fix conv backward 1d crash
7aef7c7
@DenisVieriu97 @pytorchmergebot
Fix lint issues
018c20a
@DenisVieriu97 @pytorchmergebot
Replace get_mps_conv_shape with getMPSShape; Address remaining PR com…
0f383fc 
…ments
@pytorchmergebot
Copy link
Collaborator

Successfully rebased fix_conv_grad_weights onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_conv_grad_weights && git pull --rebase)

@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (default, 4, 4, linux.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@DenisVieriu97
Copy link
Collaborator Author

@pytorchbot merge -f "Lint+MPS is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razarmehr razarmehr razarmehr approved these changes

@malfet malfet Awaiting requested review from malfet

@albanD albanD Awaiting requested review from albanD

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DenisVieriu97 @pytorchmergebot @razarmehr @pytorchbot