Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Fix 'prim::PackPadded' shape inference #91829

Closed
wants to merge 2 commits into from
Closed

[ONNX] Fix 'prim::PackPadded' shape inference #91829

wants to merge 2 commits into from

Conversation

BowenBao
Copy link
Collaborator

@BowenBao BowenBao commented Jan 6, 2023 •
edited by pytorchmergebot

Stack from ghstack (oldest at bottom):

In peephole pass, user nodes of output of prim::PackPadded are modified to consume
the input of prim::PackPadded instead. Hence the logic in shape type inference. However
only the first output requires this workaround.

Fixes #91528

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 6, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91829

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 0453040:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Jan 6, 2023
BowenBao added a commit that referenced this pull request Jan 6, 2023
@BowenBao
[ONNX] Fix 'prim::PackPadded' shape inference
47b34f5 
ghstack-source-id: 1acb7b26e9cb95a2095d1ee665afb8be9724669b
Pull Request resolved: #91829
@BowenBao BowenBao added module: onnx Related to torch.onnx topic: bug fixes topic category labels Jan 6, 2023
@BowenBao BowenBao mentioned this pull request Jan 6, 2023
Closed
@BowenBao BowenBao marked this pull request as ready for review January 6, 2023 23:23
@BowenBao BowenBao requested a review from abock as a code owner January 6, 2023 23:23
@BowenBao
Copy link
Collaborator Author

BowenBao commented Jan 9, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@BowenBao
Update on "[ONNX] Fix 'prim::PackPadded' shape inference"
0453040 
In `peephole` pass, user nodes of output of `prim::PackPadded` are modified to consume
the input of `prim::PackPadded` instead. Hence the logic in shape type inference. However
only the first output requires this workaround. 

Fixes #91528

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/BowenBao/186/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/91829)

pytorchmergebot pushed a commit that referenced this pull request Jan 9, 2023
@BowenBao
[ONNX] Fix 'prim::PackPadded' shape inference
aaa8558 
ghstack-source-id: 5fb74bad9e76b9b9b243265c2d6bbbb4ac813b9b
Pull Request resolved: #91829
@titaiwangms titaiwangms self-assigned this Jan 10, 2023
titaiwangms
titaiwangms approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-x86-64 / test (default, 1, 2, macos-12)

Details for Dev Infra team Raised by workflow job

@BowenBao
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/BowenBao/186/head branch June 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

@abock abock Awaiting requested review from abock

Assignees

@titaiwangms titaiwangms

Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bug fixes topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BowenBao @pytorchmergebot @titaiwangms @pytorchbot