Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numel() result after resizing a sparse compressed tensor. #91831

Closed
wants to merge 1 commit into from
Closed

Fix numel() result after resizing a sparse compressed tensor. #91831

wants to merge 1 commit into from

Conversation

pearu
Copy link
Collaborator

@pearu pearu commented Jan 6, 2023 •
edited by pytorch-bot bot

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 6, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91831

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit d2ba864:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pearu added a commit that referenced this pull request Jan 6, 2023
@pearu
Fix numel() result after resizing a sparse compressed tensor.
b76a728 
ghstack-source-id: d4294c007707eea318fd702f493ce7f84481ddc2
Pull Request resolved: #91831
@pearu pearu self-assigned this Jan 6, 2023
@pearu pearu added module: sparse Related to torch.sparse open source module: correctness (silent) issue that returns an incorrect result silently release notes: sparse release notes category labels Jan 6, 2023
@pearu pearu added this to In progress in Sparse tensors via automation Jan 6, 2023
@pearu pearu requested review from amjames and cpuhrsch January 6, 2023 23:08
@pearu pearu linked an issue Jan 6, 2023 that may be closed by this pull request
Resized compressed sparse tensor has wrong numel() result. #91830
Closed
nikitaved
nikitaved reviewed Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@nikitaved nikitaved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sparse tensors automation moved this from In progress to Reviewer approved Jan 9, 2023
@pearu
Copy link
Collaborator Author

pearu commented Jan 10, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 10, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@pearu pearu added the keep-going Don't stop on first failure, keep running tests until the end label Jan 10, 2023
@pearu
Copy link
Collaborator Author

pearu commented Jan 10, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sparse tensors automation moved this from Reviewer approved to Done Jan 10, 2023
@alexsamardzic alexsamardzic mentioned this pull request Jan 11, 2023
Closed
@facebook-github-bot facebook-github-bot deleted the gh/pearu/86/head branch June 8, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitaved nikitaved nikitaved left review comments

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@amjames amjames Awaiting requested review from amjames

Assignees

@pearu pearu

Labels
ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: correctness (silent) issue that returns an incorrect result silently module: sparse Related to torch.sparse open source release notes: sparse release notes category
Projects
Sparse tensors
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resized compressed sparse tensor has wrong numel() result.
4 participants
@pearu @pytorchmergebot @nikitaved @cpuhrsch