Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPS] Fix torch.topk for empty tensors and k=0 on mps #91884

Closed
wants to merge 1 commit into from
Closed

[MPS] Fix torch.topk for empty tensors and k=0 on mps #91884

wants to merge 1 commit into from

Conversation

soof-golan
Copy link
Contributor

Fixes #91878

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 9, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91884

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6fead99:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jan 9, 2023
@soof-golan soof-golan changed the title [MPS] Fix topk for empty tensors and k=0 [MPS] Fix torch.topk for empty tensors and k=0 on mps Jan 9, 2023
@soof-golan soof-golan marked this pull request as ready for review January 9, 2023 15:20
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 10, 2023
@kulinseth
Copy link
Collaborator

@soof-golan , can you please rebase and merge the change.

@soof-golan
Copy link
Contributor Author

@pytorchmergebot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 9, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulinseth kulinseth kulinseth approved these changes

Assignees
No one assigned
Labels
ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MPS] topk crashes on m1 with k=0
5 participants
@soof-golan @kulinseth @pytorchmergebot @ngimel @pytorchbot